Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer update + phpstan annotations + Improved speed. #2448

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Composer update + phpstan annotations + Improved speed. #2448

merged 3 commits into from
Jun 8, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented May 26, 2024

☠️

@ildyria ildyria marked this pull request as ready for review June 6, 2024 17:53
@ildyria ildyria requested a review from a team June 6, 2024 17:58
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jun 8, 2024
@ildyria ildyria added this to the 5.3.1 milestone Jun 8, 2024
@ildyria ildyria changed the title Composer update + more phpstan annotations 1 - Composer update + more phpstan annotations Jun 8, 2024
d7415
d7415 approved these changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of annotations!

app/Assets/Features.php Outdated Show resolved Hide resolved
ildyria and others added 2 commits June 8, 2024 14:34
@ildyria
WRTC
6f36776
@ildyria
2 - Remove some queries. (#2455)
44af7b5 
* Remove middleware when we already passed the landing point (#2456)
* Add missing primary key in Jobs_history + option to disable feedback completely. (#2457)
* Wrap collections to avoid double queries (#2458)
@ildyria ildyria changed the title 1 - Composer update + more phpstan annotations Composer update + phpstan annotations + Improved speed. Jun 8, 2024
@ildyria ildyria merged commit 728853d into master Jun 8, 2024
10 checks passed
@ildyria ildyria deleted the composer-update branch June 8, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
5.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415